Skip to content

Collect InstalledWindowsProgram installed files #2615 - #2623

Merged
pombredanne merged 6 commits into
developfrom
2615-installedwindowsprogram-installed-files-paths
Aug 5, 2021
Merged

Collect InstalledWindowsProgram installed files #2615#2623
pombredanne merged 6 commits into
developfrom
2615-installedwindowsprogram-installed-files-paths

Conversation

@JonoYang

@JonoYang JonoYang commented Aug 2, 2021

Copy link
Copy Markdown
Member

This PR introduces more file extensions that can be detected using the WinPE package parser. We also check the registry location \\Wow6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall for installed programs. populate_installed_files has also been updated to include a root_prefix argument. This argument allows us to set a root directory to the relative package file paths generated by populate_installed_files. This helps us in the case when analyzing Windows Docker images because the rootfs for Windows is stored in the Files subdirectory of the layer directory rather than the layer directory itself.

JonoYang added 5 commits July 30, 2021 16:00
    * Update tests

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * The root prefix will be passed into get_installed_packages instead of assuming that the root_prefix is always "Files"
    * Update win_pe extensions
    * Update test files

Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang
JonoYang requested a review from pombredanne August 2, 2021 18:19
Signed-off-by: Jono Yang <jyang@nexb.com>
@pombredanne pombredanne changed the title 2615 installedwindowsprogram installed files paths Collect InstalledWindowsProgram installed files paths #2615 Aug 5, 2021
@pombredanne pombredanne changed the title Collect InstalledWindowsProgram installed files paths #2615 Collect InstalledWindowsProgram installed files #2615 Aug 5, 2021

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Thanks!

@pombredanne
pombredanne merged commit 030f398 into develop Aug 5, 2021
@pombredanne
pombredanne deleted the 2615-installedwindowsprogram-installed-files-paths branch August 5, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants