Avoid misinterpreting MIT license notice as Apache-2.0, issue #2635 - #2636
Merged
Conversation
This provides a rule that matches MIT notices of form (note: indent for highlight): License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
This avoids Apache-2.0 "overriding" mit_349.RULE in cases like ## License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
pombredanne
approved these changes
Aug 13, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Clean, neat and nice.
Thank you ++
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2635
Tasks
Run tests locally to check for errors.