Skip to content

Do not mistake path for copyright year #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pombredanne merged 1 commit into from
Aug 25, 2021
+11 −1
Merged

Do not mistake path for copyright year #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cluecode/copyrights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def from_node(
# COPYRIGHT
############################################################################

# first some exceptions
# some exceptions

# NOT a copyright Copyright.txt : treat as NN
(r'^Copyright\.txt$', 'NN'),
Expand Down Expand Up @@ -581,6 +581,10 @@ def from_node(
# JUNK are things to ignore
############################################################################

# path with trailing year-like are NOT a year as in
# Landroid/icu/impl/IDNA2003 : treat as JUNK
(r'^[^\\/]+[\\/][^\\/]+[\\/].*$', 'JUNK'),

# Combo of many (3+) letters and punctuations groups without spaces is likely junk
# "AEO>>,o>>'!xeoI?o?O1/4thuA/"
# (r'((\w+\W+){3,})+', 'JUNK'),
Expand Down
4 changes: 4 additions & 0 deletions tests/cluecode/data/copyrights/year-like-path.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Landroid/icu/impl/IDNA2003;->startsWithPrefix(Ljava/lang/StringBuffer;)Z,BLACK
Landroid/icu/impl/IDNA2003;->toASCIILower(C)C,BLACK
Landroid/icu/impl/IDNA2003;->toASCIILower(Ljava/lang/CharSequence;)Ljava/lang/StringBuffer;,BLACK

2 changes: 2 additions & 0 deletions tests/cluecode/data/copyrights/year-like-path.txt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
what:
- copyrights