Report packages at top level with file level package_manifests - #2710
Merged
Conversation
See #2694 Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
packages to package_manifests packages to package_manifests
AyanSinhaMahapatra
force-pushed
the
2098-top-level-packages
branch
4 times, most recently
from
September 23, 2021 13:27
8345632 to
d609786
Compare
Modifies tests and test expectations for the change of file level attribute `packages` to `package_manifests`. Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2098-top-level-packages
branch
2 times, most recently
from
September 23, 2021 14:29
d0d1f8f to
802fe3a
Compare
Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2098-top-level-packages
branch
from
September 23, 2021 18:50
802fe3a to
6f5d3b0
Compare
Member
Author
|
@pombredanne All green! Ready to review. |
Adds `packages` codebase attribute and temporarily populate with all package manifests detected in the codebase. Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
packages to package_manifests packages at top level with file level package_manifests
pombredanne
requested changes
Sep 27, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks: see my review in line!
pombredanne
requested changes
Sep 27, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Also please update the changelog and bump the data version to 2.0
You can hold on for the doc changes, and may have separate issue for the doc to do it at once.
AyanSinhaMahapatra
force-pushed
the
2098-top-level-packages
branch
2 times, most recently
from
September 29, 2021 13:33
7d668cb to
c3cbd41
Compare
Member
Author
|
@pombredanne changes requested in the review are addressed now. |
pombredanne
requested changes
Oct 5, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes,
Some extra things for your review before we can merge.
Restores previously made changes in summarycode, and deprecates package API with a warning, and adds other small bugfixes. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Package_manifests were not being collected when there was a single file in the codebase, this fixes the bug and regenerates tests. Signed-off-by: Ayan Sinha <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2098-top-level-packages
branch
from
October 7, 2021 14:37
1628123 to
c90dedb
Compare
pombredanne
requested changes
Oct 7, 2021
Member
Author
|
All green now. |
pombredanne
approved these changes
Oct 8, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... merging: thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2694
Tasks
Run tests locally to check for errors.