Skip to content

Fix azure pipeline vmimage deprecations - #2775

Merged
pombredanne merged 1 commit into
developfrom
fix-azure-deprecations
Dec 3, 2021
Merged

Fix azure pipeline vmimage deprecations#2775
pombredanne merged 1 commit into
developfrom
fix-azure-deprecations

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented Dec 1, 2021

Copy link
Copy Markdown
Member

macos-10.14 and vs2017-win2016 vm images are deprecated and
this replaces them with newer images.

See https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/

macos-10.14 would be deprecated on December 10, 2021
vs2017-win2016 would be deprecated on March 15, 2022

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

`macos-10.14` and `vs2017-win2016` vm images are deprecated and
this replaces them with newer images.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we should keep also the oldest supported versions first and it's OK to also add newest 11 and 2022 versions like you did... but we cannot only support the latest and greatest.

Comment thread azure-pipelines.yml
Comment thread azure-pipelines.yml
@AyanSinhaMahapatra

AyanSinhaMahapatra commented Dec 3, 2021

Copy link
Copy Markdown
Member Author

I looked into the images available here and here

In windows we already did the tests on windows-2019, it is just below the windows-2022 test. These are the only two images listed above.

In MacOS, there are only three, 10.14, 10.15 and 11, of which 10.14 will be deprecated and removed soon. So replaced those tests too.

Also note that I removed python 3.6 in the newer images, as they are not supported and not present so were generating errors.

Do you also mean the ordering on the tests in the azure-pipelines.yml file? Like the windows-2019 should be before the windows-2022 test?

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also mean the ordering on the tests in the azure-pipelines.yml file? Like the windows-2019 should be before the windows-2022 test?

No, we are all good as it is ... thank you ++... merging!

@pombredanne
pombredanne merged commit 1dfd73a into develop Dec 3, 2021
@pombredanne
pombredanne deleted the fix-azure-deprecations branch December 3, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants