Skip to content

Fixed inconsistency in --html-app FILE in cli-reference - #2790

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
maynaS:develop
Jan 24, 2022
Merged

Fixed inconsistency in --html-app FILE in cli-reference#2790
pombredanne merged 1 commit into
aboutcode-org:developfrom
maynaS:develop

Conversation

@maynaS

@maynaS maynaS commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Fixes #2789

Before

scancode -clpieu --csv output.html samples

After

scancode -clpieu --html-app output.html samples

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
    It is a small documentation change, therefore I pushed it to the develop branch itself.

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maynaS Thank you ++
You need to format you signoff, it must be on the last line of your commit message.
Also do you mind to squash all in a single clean commit with a single clean message?

@pombredanne

Copy link
Copy Markdown
Member

Thanks! Do you mind to squash your commits in a single one with
A subject that's less than 50 characters
A signoff on the last line of the message

Signed-off-by: maynaS <samjshah2002@gmail.com>
@maynaS

maynaS commented Jan 15, 2022

Copy link
Copy Markdown
Contributor Author

@pombredanne Hey, can you check it out? I have done what you asked for

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
LGTM, merging!

@pombredanne
pombredanne merged commit 0b57869 into aboutcode-org:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency in documentation of --html-app FILE in Command Line Interface Reference

2 participants