Fixed inconsistency in --html-app FILE in cli-reference - #2790
Merged
Conversation
pombredanne
requested changes
Jan 8, 2022
pombredanne
left a comment
Member
There was a problem hiding this comment.
@maynaS Thank you ++
You need to format you signoff, it must be on the last line of your commit message.
Also do you mind to squash all in a single clean commit with a single clean message?
Member
|
Thanks! Do you mind to squash your commits in a single one with |
Signed-off-by: maynaS <samjshah2002@gmail.com>
Contributor
Author
|
@pombredanne Hey, can you check it out? I have done what you asked for |
pombredanne
approved these changes
Jan 24, 2022
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thank you ++
LGTM, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2789
Before
scancode -clpieu --csv output.html samplesAfter
scancode -clpieu --html-app output.html samplesTasks
Run tests locally to check for errors.
It is a small documentation change, therefore I pushed it to the develop branch itself.