Skip to content

2789 inconsistent doc html app - #2795

Merged
pombredanne merged 3 commits into
aboutcode-org:developfrom
kunalchhabra37:2789-inconsistent-doc-html-app
Jan 24, 2022
Merged

2789 inconsistent doc html app#2795
pombredanne merged 3 commits into
aboutcode-org:developfrom
kunalchhabra37:2789-inconsistent-doc-html-app

Conversation

@kunalchhabra37

@kunalchhabra37 kunalchhabra37 commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Kunal Chhabra <kunalchhabra37@gmail.com>
Signed off by: Kunal Chhabra <kunalchhabra37@gmail.com> fixed inconsistency in documentation aboutcode-org#2789
Signed off by- Kunal Chhabra <kunalchhabra37@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunal: Thank you ... well spotted!

There are some inconsistencies in your DCO signoff, but one of them is good, so I will squash and merge.

@pombredanne
pombredanne merged commit 0e4fe27 into aboutcode-org:develop Jan 24, 2022
@pombredanne

Copy link
Copy Markdown
Member

Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants