Skip to content

Fix incorrect license detection #2777 - #2811

Merged
pombredanne merged 3 commits into
aboutcode-org:developfrom
kji22:false-positive-2777
Feb 1, 2022
Merged

Fix incorrect license detection #2777#2811
pombredanne merged 3 commits into
aboutcode-org:developfrom
kji22:false-positive-2777

Conversation

@kji22

@kji22 kji22 commented Jan 25, 2022 •
edited by pombredanne
Loading

Copy link
Copy Markdown
Contributor

Adds a false positive rule for GNU tar. Also removes the public domain license as one of the expected outputs of the Debian slim copyright license test because the test has the same bug as the linked issue. Fixes #2777.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@kji22

kji22 commented Jan 25, 2022

Copy link
Copy Markdown
Contributor Author

@pombredanne the one test that fails after applying this change is the exact same bug reported in #2777. The expected output for the test is located on line 3 of tests/packagedcode/data/debian/copyright/debian-slim-2021-04-07/usr/share/doc/tar/copyright-detailed.expected.yml, and you can see that the test also expects a public-domain license.

Does this mean the test's expected output is incorrect? If it is, I can also fix the test. Or is #2777 actually not a bug?

@pombredanne pombredanne mentioned this pull request Jan 26, 2022
Closed
@pombredanne

pombredanne commented Jan 26, 2022

Copy link
Copy Markdown
Member

@KevinJi22 This is not a clear cut... See #2777 (comment)

kji22 added 2 commits January 31, 2022 10:01
@kji22
Fix incorrect license detection aboutcode-org#2777
29f1784 
Adds a false positive rule for GNU tar. Fixes aboutcode-org#2777

Signed-off-by: Kevin Ji <kyji1011@gmail.com>
@kji22
Fix Debian copyright test expected output aboutcode-org#2777
b0b63a6 
This removes the public domain license that was previously one of the
expected outputs of the Debian Slim Copyright license detection test.
The public domain license is not an actual license for this GNU tar
file.

Signed-off-by: Kevin Ji <kyji1011@gmail.com>
@kji22
kji22 force-pushed the false-positive-2777 branch from 8a0e4f0 to b0b63a6 Compare January 31, 2022 18:17
@pombredanne

pombredanne commented Feb 1, 2022

Copy link
Copy Markdown
Member

@KevinJi22 this is a bug alright as documented in #2777 (comment)

@kji22

kji22 commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

@pombredanne Yup, I fixed the bug in the second commit by removing the public domain license as one of the test's expected outputs.

pombredanne
pombredanne approved these changes Feb 1, 2022
View reviewed changes

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failure in https://github.com/nexB/scancode-toolkit/runs/5010476784?check_suite_focus=true is not your making. Looking all good... Merging now!
Thank you ++

@pombredanne
pombredanne merged commit bebbcf7 into aboutcode-org:develop Feb 1, 2022
@kji22
kji22 deleted the false-positive-2777 branch February 1, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect license detection

2 participants

@kji22 @pombredanne