Skip to content

Add Direct Note for Windows Users (New Comers) - #2857

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
OsmiumOP:newcomers-docs-update-osmiumop
Feb 10, 2022
Merged

Add Direct Note for Windows Users (New Comers)#2857
pombredanne merged 1 commit into
aboutcode-org:developfrom
OsmiumOP:newcomers-docs-update-osmiumop

Conversation

@OsmiumOP

@OsmiumOP OsmiumOP commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: OsmiumOP harshbansal.contact@gmail.com

Fixes #2845
Recreated due to some issues with previous ones.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Still trying to get my First Small PR get merged. Wish me luck and I look forward to advice on how I can improvise.

Signed-off-by: OsmiumOP <harshbansal.contact@gmail.com>
@OsmiumOP
OsmiumOP force-pushed the newcomers-docs-update-osmiumop branch from 2895acb to ff2fcc1 Compare February 7, 2022 14:47
@OsmiumOP

OsmiumOP commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

@pombredanne Fixed all issues that existed in the old PR. Please check and let me know if something else is needed.

@pombredanne

Copy link
Copy Markdown
Member

pytest-dev/pytest#9608 is likely the cause for the failures

@OsmiumOP

OsmiumOP commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

@pombredanne so is there a solution for me to execute? or will you approve and merge as it is?

@the-illuminatus

Copy link
Copy Markdown

is this issue open ?

@OsmiumOP

OsmiumOP commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

is this issue open ?

The Tests Failing? yes

Comment thread docs/source/getting-started/newcomer.rst
@pombredanne
pombredanne merged commit 3d6434f into aboutcode-org:develop Feb 10, 2022
@OsmiumOP
OsmiumOP deleted the newcomers-docs-update-osmiumop branch February 10, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct Link to Docs for Windows Users

4 participants