Make --version output valid YAML for parsing #2856 - #2858
Merged
Conversation
kji22
force-pushed
the
version-output-2856
branch
from
February 8, 2022 05:01
7404481 to
9f177fd
Compare
pombredanne
requested changes
Feb 8, 2022
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks!
Could you add a small test to validate that this function returns valid YAML that can be parsed?
This commit adds a colon so the --version output goes from ScanCode version 30.1.0 ScanCode Output Format version 2.0.0 SPDX License list version 3.15 to ScanCode version: 30.1.0 ScanCode Output Format version: 2.0.0 SPDX License list version: 3.15 This will make the output easier to parse since it is valid YAML now. This also includes a test validating this behavior. Signed-off-by: Kevin Ji <kyji1011@gmail.com>
kji22
force-pushed
the
version-output-2856
branch
from
February 8, 2022 08:16
9f177fd to
b78b49f
Compare
Member
|
pytest-dev/pytest#9608 is likely the cause for the failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a colon so instead of getting
we get
This will make the output easier to parse since it is valid YAML now. Fixes #2856
Tasks
Run tests locally to check for errors.