Remove version check locally - #2860
Merged
pombredanne merged 1 commit intoFeb 14, 2022
Merged
Conversation
adityasangave
force-pushed
the
local_version_check
branch
3 times, most recently
from
February 9, 2022 13:30
9ae0389 to
0a0deae
Compare
pombredanne
reviewed
Feb 10, 2022
| if not outdated and check_version: | ||
| from scancode.outdated import check_scancode_version_remotely | ||
| outdated = check_scancode_version_remotely() | ||
| # Check for updates |
Member
There was a problem hiding this comment.
This should ONLY happen if check_version. This way folks can elect to not do any such check
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
adityasangave
force-pushed
the
local_version_check
branch
from
February 10, 2022 13:36
0a0deae to
6934b61
Compare
pombredanne
approved these changes
Feb 14, 2022
pombredanne
left a comment
Member
There was a problem hiding this comment.
Looks good!
Thank you ++... merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2796
Tasks
Run tests locally to check for errors.