Skip to content

Modify pypi PKG-INFO parse - #2953

Merged
pombredanne merged 1 commit into
developfrom
fix-2943-pkg-info-bug
May 13, 2022
Merged

pombredanne merged 1 commit into
developfrom
fix-2943-pkg-info-bug

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented May 11, 2022

Copy link
Copy Markdown
Member

Reference: #2943
Do not return 2 PackageData objects when there are PKG-INFO files.

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@JonoYang

Copy link
Copy Markdown
Member

@AyanSinhaMahapatra LGTM!

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See my nits!

Comment thread src/packagedcode/pypi.py Outdated
Reference: #2943
Do not return 2 PackageData objects when there are PKG-INFO files.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pombredanne
pombredanne merged commit 45b57e5 into develop May 13, 2022
@pombredanne
pombredanne deleted the fix-2943-pkg-info-bug branch May 13, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants