Skip to content

Report extracted_requirement correctly - #2984

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
TG1999:fix_pypi_model
Jun 12, 2022
Merged

pombredanne merged 1 commit into
aboutcode-org:developfrom
TG1999:fix_pypi_model

Conversation

@TG1999

@TG1999 TG1999 commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Fixes #2983

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra

AyanSinhaMahapatra commented Jun 7, 2022

Copy link
Copy Markdown
Member

LGTM! Thanks.

Reference: aboutcode-org#2983
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 changed the title Reference: https://github.com/nexB/scancode-toolkit/issues/2983 fix get_requires_dependencies Jun 7, 2022
@pombredanne pombredanne changed the title fix get_requires_dependencies Report extracted_requirement correctly Jun 7, 2022

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pombredanne

Copy link
Copy Markdown
Member

These test is failing likely from the updated results:
tests/packagedcode/test_pypi.py::TestPyPiEndtoEnd::test_package_scan_pypi_end_to_end

@pombredanne

Copy link
Copy Markdown
Member

tests/packagedcode/test_pypi.py::TestPyPiEndtoEnd::test_package_scan_pypi_end_to_end is failing only in the CI. Merging anyway.

@pombredanne
pombredanne merged commit 9d885d5 into aboutcode-org:develop Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_requires_dependencies gives out specifier in extracted_requirement

3 participants