Skip to content

Correct purl type for cocoapods #3081 - #3096

Merged
AyanSinhaMahapatra merged 1 commit into
developfrom
3081-correct-type-cocoapods
Sep 12, 2022
Merged

Correct purl type for cocoapods #3081#3096
AyanSinhaMahapatra merged 1 commit into
developfrom
3081-correct-type-cocoapods

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented Sep 7, 2022

Copy link
Copy Markdown
Member
  • Modify purl type for cocoapods packages and deps from pods to the correct type cocoapods.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do you mind to add a changelog entry too?

* Modify purl type for cocoapods packages and deps from `pods`
  to the correct type `cocoapods`.

Reference: #3081
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
AyanSinhaMahapatra force-pushed the 3081-correct-type-cocoapods branch from 5647e26 to bf78589 Compare September 12, 2022 08:50
@AyanSinhaMahapatra

Copy link
Copy Markdown
Member Author

@pombredanne added the changelog entry, thanks!

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All clear. Please merge

@AyanSinhaMahapatra
AyanSinhaMahapatra merged commit 6007301 into develop Sep 12, 2022
@pombredanne
pombredanne deleted the 3081-correct-type-cocoapods branch September 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants