Skip to content

Add required phrase to JSR rule - #3218

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
bennati:fix-jsr-rule
Jan 30, 2023
Merged

Add required phrase to JSR rule#3218
pombredanne merged 1 commit into
aboutcode-org:developfrom
bennati:fix-jsr-rule

Conversation

@bennati

@bennati bennati commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

Avoids ambiguity with other rules

Signed-off-by: Bennati, Stefano stefano.bennati@here.com

Signed-off-by: Bennati, Stefano <stefano.bennati@here.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@bennati
bennati requested a review from pombredanne January 30, 2023 12:57
@pombredanne
pombredanne merged commit 6358a4b into aboutcode-org:develop Jan 30, 2023
@bennati
bennati deleted the fix-jsr-rule branch January 31, 2023 10:31
@zhernovs

zhernovs commented Apr 5, 2023

Copy link
Copy Markdown

Hi @pombredanne
Is there any chance to include this into some 31.* patch?
We would love to use newer version of scancode (currently on 30.1.0) together with ORT. But ORT still doesn't support new output format version that you have in 32.* On the other hand we can't use 31.* without a fix from this commit. Perhaps another patch version (31.2.5) won't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants