Conversation
added 4 commits
January 26, 2023 05:41
Signed-off-by: Ninad Ambade <ninad.ambade@aploris.com>
AyanSinhaMahapatra
requested changes
Jan 30, 2023
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
-
See https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=9807&view=logs&j=5ccb487c-030c-5c4a-6db4-16909ae49dc7&t=b50f1525-6eb8-588a-b5ae-b2a59d2d4632, you also have to add a new .LICENSE file for this, for this to be added as a valid
license-key. -
This has ~320 appearances in github: https://github.com/search?q=King+Fahd+Glorious+Quran+Printing+Complex&type=code, and we can probably add more rules from here?
…into develop # Conflicts: # src/licensedcode/data/rules/kfgqpc-uthmanic-script-hafs.RULE
Author
|
Closing this pull request to avoid unnecessary clutter, creating a new one #3234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ninad Ambade ninadambade@gmail.com
Fixes #3225
Tasks
Run tests locally to check for errors.