Skip to content

support parsing BUNDLED WITH - #3444

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
akostadinov:develop
Jun 30, 2023
Merged

support parsing BUNDLED WITH#3444
pombredanne merged 1 commit into
aboutcode-org:developfrom
akostadinov:develop

Conversation

@akostadinov

@akostadinov akostadinov commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Gemfile.lock contains information about the version of Bundler used to generate it. Presently this information is not parse-able no matter if Bundler is only used to generate the file or is also a dependency of the project.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@akostadinov akostadinov changed the title <!-- Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! * [x] - Checked Box * [ ] - Unchecked Box --> support parsing BUNDLED WITH Jun 30, 2023
Signed-off-by: Aleksandar N. Kostadinov <akostadi@redhat.com>
@pombredanne

Copy link
Copy Markdown
Member

Thank you ++ for this! ❤️

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you: this is neat, clean and tested. You rock.

@pombredanne
pombredanne merged commit a15174f into aboutcode-org:develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants