#99 license detection in binaries fails sometime - #353
Merged
Conversation
* Copied from https://raw.githubusercontent.com/fireeye/flare-floss/0db13aff88d0487f818f19a36de879dc27c94e13/floss/strings.py * Apache-licensed Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* moved stlport-2000 and rules to "notices" and added test * deleted halpern-wight which is a dupe of stlport-4.5 * added various rules for mozilla-gc and stlport-related licenses * added new historical rules (for stlport-200 detection) Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* this is a subset of the strings extracted from libgcj.so.10.0.0 originally from http://vault.centos.org/6.4/cr/x86_64/Packages/libgcj-4.4.7-4.el6.i686.rpm /usr/lib/libgcj.so.10.0.0 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* otherwise too many query runs are created Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* use a regex-based approach as in fireeye's floss * simplify filtering * now supporting UTF-16 strings in Windows PE Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* This is no longer needed now that we have a more accurate detection Also updated rules and tests accordingly. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* ensure that we do not merge matches that would result in unaligned ispan/qspan * keep the densest of two matches overlapping with equal ispans Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Prior to this, strings needed to have at least three unique characters which was a mistake.
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* remove duplicated SPDX text * remove copyright statement Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* add new rules and texts (including a general CLA) * refine frequent tokens * add new disambiguation with a filter for matches that overlap multiple matches * correct the licensing identifier of rules that were all incorrect (and were set to False) Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* handle better some trailing words and complex university names * handle "Portions Copyright ..." Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
99-license-in-binary
branch
from
November 4, 2016 21:26
883624c to
b55d003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits provide a fox #99 and bring several derived improvements that were needed or peripheral to the fix.