Add support for buildpack.toml files - #4031
Open
NucleonGodX wants to merge 10 commits into
Open
Conversation
NucleonGodX
force-pushed
the
issue3477
branch
from
December 19, 2024 07:01
266b903 to
cd1ec55
Compare
NucleonGodX
marked this pull request as draft
December 19, 2024 07:18
NucleonGodX
marked this pull request as ready for review
December 23, 2024 09:37
NucleonGodX
marked this pull request as draft
December 24, 2024 04:52
NucleonGodX
marked this pull request as ready for review
December 24, 2024 13:55
…pack package Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
NucleonGodX
force-pushed
the
issue3477
branch
from
December 31, 2024 10:08
418fb5d to
afaba83
Compare
AyanSinhaMahapatra
requested changes
Jan 14, 2025
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks++ @NucleonGodX for the PR!
This is a great start.
See my comments for your consideration.
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
NucleonGodX
force-pushed
the
issue3477
branch
from
January 18, 2025 15:43
85b2ccd to
5399fdd
Compare
Contributor
Author
|
Thanks @AyanSinhaMahapatra for your suggestions, I've implemented them. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
AyanSinhaMahapatra
requested changes
Apr 25, 2025
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
@NucleonGodX thanks++ for your changes, see comments for some more improvements, and this should be ready to merge after.
Contributor
Author
|
Hey @AyanSinhaMahapatra, thanks for your suggestions, I will apply them in a few days. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Contributor
Author
|
@AyanSinhaMahapatra I've applied almost all your suggestions, a few are left that I'll apply by tomorrow. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Contributor
Author
|
Applied All suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3477
Tasks
Run tests locally to check for errors.
Signed-off-by: NucleonGodX manitsingh018@gmail.com