Skip to content

Correct license merge tutorials - #4473

Open
chinyeungli wants to merge 4 commits into
developfrom
correct_license_merge_tutorials
Open

Correct license merge tutorials#4473
chinyeungli wants to merge 4 commits into
developfrom
correct_license_merge_tutorials

Conversation

@chinyeungli

Copy link
Copy Markdown
Contributor

Fixes
#2168 - Update license in documentation
#1980 - Merge tutorials and how-to guides

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Failing tests don't related to this PR.

Signed-off-by: Chin Yeung Li tli@nexb.com

Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinyeungli the documentation license change looks good, but I am inclined to keep the documentation sections seperate as explained in: #1980 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants