cli: Add a fallback to calculate the SHA1 if it is not present in the cache - #459
Conversation
|
@sschuberth Thanks! |
|
I agree that adding hashes even for empty files is more consistent. However, you also told me I shouldn't rely on cache internals, and maybe at some point the info does not expose the SHA1 anymore, so having a fallback to calculate it might make sense anyway. WRT storing info about empty files, maybe instead of introducing a whole new flag, consider adding another type in |
|
The info will always expose a sha1 (the fact that it is also used as a cache key is the only "internal" implementation part). And you got it right: that would be a new flag in |
|
@sschuberth I am merging this for now so this is not in your way and I created #461 to update the behavior |
@pombredanne I've updated the PR with a commit that addresses your
TODOof writing aLicenseReffor licenses not known to SPDX.