Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/formattedcode/output_html.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,16 @@ def process_codebase(self, codebase, html, **kwargs):
license_references = []
if hasattr(codebase.attributes, 'license_references'):
license_references = codebase.attributes.license_references
summary = None
if hasattr(codebase.attributes, 'summary'):
summary = codebase.attributes.summary
template_loc = join(TEMPLATES_DIR, 'html', 'template.html')
output_file = html
write_templated(
output_file=output_file,
results=results,
license_references=license_references,
summary=summary,
version=version,
template_loc=template_loc,
)
Expand Down Expand Up @@ -133,18 +137,22 @@ def process_codebase(self, codebase, custom_output, custom_template, **kwargs):
license_references = []
if hasattr(codebase.attributes, 'license_references'):
license_references = codebase.attributes.license_references
summary = None
Comment thread
uttam282005 marked this conversation as resolved.
Outdated
if hasattr(codebase.attributes, 'summary'):
summary = codebase.attributes.summary
template_loc = custom_template
output_file = custom_output
write_templated(
output_file=output_file,
results=results,
license_references=license_references,
summary=summary,
version=version,
template_loc=template_loc
)


def write_templated(output_file, results, license_references, version, template_loc):
def write_templated(output_file, results, license_references, summary, version, template_loc):
"""
Write scan output `results` to the `output_file` opened file using a template
file at `template_loc`.
Expand All @@ -155,6 +163,7 @@ def write_templated(output_file, results, license_references, version, template_
for template_chunk in generate_output(
results=results,
license_references=license_references,
summary=summary,
version=version,
template=template,
):
Expand Down Expand Up @@ -184,7 +193,7 @@ def get_template(location):
return env.get_template(template_name)


def generate_output(results, license_references, version, template):
def generate_output(results, license_references, summary, version, template):
"""
Yield unicode strings from incrementally rendering `results` and `version`
with the Jinja `template` object.
Expand All @@ -197,7 +206,7 @@ def generate_output(results, license_references, version, template):
converted = {}
converted_infos = {}
converted_packages = {}
licenses = {}
licenses = {}
Comment thread
uttam282005 marked this conversation as resolved.
Outdated

LICENSES = 'license_detections'
COPYRIGHTS = 'copyrights'
Expand All @@ -223,12 +232,20 @@ def generate_output(results, license_references, version, template):
if TRACE:
logger_debug(f"match: {match}")
license_expression = match['license_expression']
results.append({
match_data = {
'start': match['start_line'],
'end': match['end_line'],
'what': 'license',
'value': license_expression,
})
}

if 'matched_text' in match:
match_data['matched_text'] = match['matched_text']

if 'matched_text_diagnostics' in match:
match_data['matched_text_diagnostics'] = match['matched_text_diagnostics']

results.append(match_data)

if not license_references and license_expression not in licenses:
license_object = get_licenses_db().get(license_expression)
Expand Down Expand Up @@ -261,7 +278,7 @@ def generate_output(results, license_references, version, template):
'package_data': converted_packages
}

return template.generate(files=files, license_references=license_references, version=version)
return template.generate(files=files, license_references=license_references, summary=summary, version=version)


@output_impl
Expand Down
110 changes: 110 additions & 0 deletions src/formattedcode/templates/html/template.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,101 @@
font-weight: normal;
font-size: 12px;
}
details {
margin: 5px 0;
}
summary {
cursor: pointer;
color: #5E81B7;
font-weight: bold;
}
summary:hover {
text-decoration: underline;
}
pre {
background: #f5f5f5;
padding: 10px;
border: 1px solid #ddd;
overflow-x: auto;
font-family: monospace;
font-size: 11px;
white-space: pre-wrap;
word-wrap: break-word;
}
.summary-section {
background: #f0f8ff;
padding: 15px;
margin-bottom: 20px;
border-left: 4px solid #5E81B7;
}
.summary-section h3 {
margin-top: 0;
color: #5E81B7;
font-size: 16px;
}
.summary-section p {
margin: 5px 0;
}
Comment thread
uttam282005 marked this conversation as resolved.
Outdated
</style>
</head>
<body>
{% if summary %}
<div class="summary-section">
<h3>Scan Summary</h3>
{% if summary.declared_license_expression %}
<p><strong>Declared License:</strong> {{ summary.declared_license_expression }}</p>
{% endif %}
{% if summary.declared_holder %}
<p><strong>Declared Holder:</strong> {{ summary.declared_holder }}</p>
{% endif %}
{% if summary.primary_language %}
<p><strong>Primary Language:</strong> {{ summary.primary_language }}</p>
{% endif %}
{% if summary.other_license_expressions %}
<p><strong>Other License Expressions:</strong></p>
<ul>
{% for expr in summary.other_license_expressions %}
<li>{{ expr.value }} (count: {{ expr.count }})</li>
{% endfor %}
</ul>
{% endif %}
{% if summary.other_holders %}
<p><strong>Other Holders:</strong></p>
<ul>
{% for holder in summary.other_holders %}
<li>{{ holder }}</li>
Comment thread
uttam282005 marked this conversation as resolved.
Outdated
{% endfor %}
</ul>
{% endif %}
</div>
{% endif %}
{% if summary and summary.license_clarity_score %}
<table>
<caption>License Clarity Score</caption>
<thead>
<tr>
<th>Overall Score</th>
<th>Declared License</th>
<th>Identification Precision</th>
<th>Has License Text</th>
<th>Declared Copyrights</th>
<th>Ambiguous Compound</th>
<th>Conflicting Categories</th>
</tr>
</thead>
<tbody>
<tr>
<td><strong>{{ summary.license_clarity_score.score }}</strong></td>
<td>{{ summary.license_clarity_score.declared_license }}</td>
<td>{{ summary.license_clarity_score.identification_precision }}</td>
<td>{{ summary.license_clarity_score.has_license_text }}</td>
<td>{{ summary.license_clarity_score.declared_copyrights }}</td>
<td>{{ summary.license_clarity_score.ambiguous_compound_licensing }}</td>
<td>{{ summary.license_clarity_score.conflicting_license_categories }}</td>
</tr>
</tbody>
</table>
{% endif %}
{% if files.license_copyright %}
<table>
<caption>Copyrights and Licenses Information</caption>
Expand All @@ -59,6 +151,7 @@
<th>end</th>
<th>what</th>
<th>value</th>
<th>matched text/ diagnostics</th>
</tr>
</thead>
<tbody>
Expand All @@ -71,6 +164,23 @@
<td>{{ row.what }}</td>
{% if row.what == 'license' %}
<td><a href="#license_{{ row.value }}">{{ row.value }}</a></td>
<td>
{% if row.matched_text %}
<details>
<summary>View Matched Text</summary>
<pre>{{ row.matched_text|escape }}</pre>
</details>
{% endif %}
{% if row.matched_text_diagnostics %}
<details>
<summary>View Diagnostics</summary>
<pre>{{ row.matched_text_diagnostics|escape }}</pre>
</details>
{% endif %}
{% if not row.matched_text and not row.matched_text_diagnostics %}
-
{% endif %}
</td>
{% else %}
<td>{{ row.value|escape }}</td>
Comment thread
uttam282005 marked this conversation as resolved.
{% endif %}
Expand Down
40 changes: 40 additions & 0 deletions tests/formattedcode/test_output_templated.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,46 @@ def test_paths_are_posix_in_html_format_output():
assert '/copyright_acme_c-c.c' in results
assert __version__ in results

@pytest.mark.scanslow
def test_html_output_includes_license_text():
test_file = test_env.get_test_loc('templated/simple-license.txt')
result_file = test_env.get_temp_file('html')
run_scan_click(['--license', '--license-text', test_file, '--html', result_file])
results = open(result_file).read()
Comment thread
uttam282005 marked this conversation as resolved.
assert 'matched text' in results.lower()
assert '<pre>' in results # Check for formatted text display
assert __version__ in results

@pytest.mark.scanslow
def test_html_output_includes_license_text_diagnostics():
test_file = test_env.get_test_loc('templated/simple-license.txt')
result_file = test_env.get_temp_file('html')
run_scan_click(['--license', '--license-text', '--license-text-diagnostics',
test_file, '--html', result_file])
results = open(result_file).read()
Comment thread
uttam282005 marked this conversation as resolved.
assert 'diagnostics' in results.lower()
assert __version__ in results

@pytest.mark.scanslow
def test_html_output_includes_license_clarity_score():
test_dir = test_env.get_test_loc('templated/simple')
result_file = test_env.get_temp_file('html')
run_scan_click(['--license', '--classify', '--license-clarity-score',
test_dir, '--html', result_file])
results = open(result_file).read()
Comment thread
uttam282005 marked this conversation as resolved.
assert 'License Clarity Score' in results
assert 'score' in results.lower()
assert __version__ in results

@pytest.mark.scanslow
def test_html_output_includes_summary():
test_dir = test_env.get_test_loc('templated/simple')
result_file = test_env.get_temp_file('html')
run_scan_click(['--license', '--classify', '--summary',
test_dir, '--html', result_file])
results = open(result_file).read()
Comment thread
uttam282005 marked this conversation as resolved.
assert 'Scan Summary' in results
assert __version__ in results

@pytest.mark.scanslow
def test_scanned_path_is_present_in_html_app_output():
Expand Down
Loading