Skip to content

#447 restore default behavior of v1.x to return a root path by default - #518

Merged
pombredanne merged 3 commits into
developfrom
447-rooted-paths
Feb 26, 2017
Merged

pombredanne merged 3 commits into
developfrom
447-rooted-paths

Conversation

@pombredanne

Copy link
Copy Markdown
Member
  • the new option "--strip-root" does not add a root directory segment

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

@pombredanne

Copy link
Copy Markdown
Member Author

@jdaguil @nspsjsu Ready for you to test!

@jdaguil

jdaguil commented Feb 25, 2017

Copy link
Copy Markdown
Contributor

@pombredanne LGTM! ⭐

@pombredanne
pombredanne force-pushed the 447-rooted-paths branch 2 times, most recently from 7ef46f2 to b216889 Compare February 25, 2017 22:26
 * the new option "--strip-root" does not add a root directory segment

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne

Copy link
Copy Markdown
Member Author

@sschuberth heads up! This is being merged tomorrow. Note that with #520 you should be able to have a config file that could always --strip-root if this is what you prefer.

@sschuberth

Copy link
Copy Markdown
Collaborator

Thanks for the notice. I'll take care of adding --strip-root on our side.

@pombredanne

Copy link
Copy Markdown
Member Author

@sschuberth thank you for the quick reply! I can merge now then.

@pombredanne
pombredanne merged commit 60db756 into develop Feb 26, 2017
@pombredanne
pombredanne deleted the 447-rooted-paths branch February 26, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants