Skip to content

Better copyrights - #5224

Merged
AyanSinhaMahapatra merged 15 commits into
developfrom
better-copyrights
Aug 28, 2026
Merged

Better copyrights#5224
AyanSinhaMahapatra merged 15 commits into
developfrom
better-copyrights

Conversation

@pombredanne

@pombredanne pombredanne commented Jul 6, 2026

Copy link
Copy Markdown
Member

This PR handles some edge cases for copyrights with parens like with trailing Author(s). or other cases of damaged PDF converted to text.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

heliocastro and others added 13 commits July 2, 2026 11:05
Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
For copyright with parens

Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
This help make the function reusable for use elsewhere.

Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
this is for AUTHDOT cases

Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Reference: #5125
Reference: #5225
Reported-by: Frank Viernau @fviernau
Assisted-by:  Helio Chissini de Castro @heliocastro
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
@pombredanne

Copy link
Copy Markdown
Member Author

@fviernau @heliocastro review welcome :)

Signed-off-by: Philippe Ombredanne <pombredanne@aboutcode.org>
@heliocastro

Copy link
Copy Markdown
Contributor

So. a did a quick overview, you know that 249 files is a "little" human difficult.
I'm ok with this PR, i'm missing a three steps test cases, like what was, what is doing now and that we expected.

@heliocastro

Copy link
Copy Markdown
Contributor

@pombredanne Btw, I'm. Not allowed to do reviews

Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne thanks++ LGTM

@AyanSinhaMahapatra
AyanSinhaMahapatra merged commit 0c66f8a into develop Aug 28, 2026
42 checks passed
@AyanSinhaMahapatra
AyanSinhaMahapatra deleted the better-copyrights branch August 28, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in detection of a copyright statement

3 participants