Add back the missing argument for assemble_extracted_gem() #5306 - #5307
Merged
AyanSinhaMahapatra merged 2 commits intoSep 11, 2026
Merged
Conversation
Signed-off-by: Chin Yeung Li <tli@nexb.com>
AyanSinhaMahapatra
force-pushed
the
5306_fix_missing_argument_in_assemble_extracted_gem
branch
from
September 11, 2026 13:02
0cd25ba to
68d8cfb
Compare
AyanSinhaMahapatra
approved these changes
Sep 11, 2026
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks @chinyeungli LGTM!
I added a test as we should have caught this there, while testing a rubygems extracted gem package assembly.
| from scancode_config import REGEN_TEST_FIXTURES | ||
|
|
||
| # TODO: Add test with https://rubygems.org/gems/pbox2d/versions/1.0.3-java | ||
| # this is a multiple personality package (Java and Ruby) |
Member
There was a problem hiding this comment.
Added in a test json-3.0.2-java.gem
Reference: #5306 Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
AyanSinhaMahapatra
force-pushed
the
5306_fix_missing_argument_in_assemble_extracted_gem
branch
from
September 11, 2026 13:07
68d8cfb to
367d836
Compare
AyanSinhaMahapatra
deleted the
5306_fix_missing_argument_in_assemble_extracted_gem
branch
September 11, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5306
This is a very simple PR that add back the missing 'package_adder' argument to the assemble_extracted_gem()
Tasks
Run tests locally to check for errors.
Signed-off-by: Chin Yeung Li tli@nexb.com