Fix author detection for compact dotted names (#4229) - #5308
Open
Hrithikcrick wants to merge 2 commits into
Open
Fix author detection for compact dotted names (#4229)#5308Hrithikcrick wants to merge 2 commits into
Hrithikcrick wants to merge 2 commits into
Conversation
Signed-off-by: Hrithik Sharma <sharmahrithik2806@gmail.com>
Signed-off-by: Hrithik Sharma <sharmahrithik2806@gmail.com>
Author
|
Updated after CI validation: the broad dotted-name lexer behavior was removed and the handling is now scoped to Author context. The previously failing license-validation shards pass locally, the full Azure build now succeeds with 0 errors, and ReadTheDocs is green. The remaining GitHub Actions workflows are awaiting maintainer approval. Ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4229
Summary
Fixes author detection for compact dotted author declarations such as:
The implementation is intentionally scoped to author-tag context so unrelated dotted tokens are not globally classified as names.
Changes
Author:declarations before tokenization.Authortag.Testing
git diff --check: clean.Files changed
src/cluecode/copyrights.pytests/cluecode/test_copyrights_basic.py