Accept all PEP 508 operators in python_version markers - #5310
Open
Daksha1611 wants to merge 1 commit into
Open
Conversation
…5309 The list of operators accepted by get_python_version_os() contained '<' twice and was missing '>', so a dependency marker such as "python_version > '3.8'" never matched and was silently dropped from the DependentPackage extra_data, while ">=" was reported correctly. The '!=' and '~=' operators were missing for the same reason. Replace the duplicated '<' with the full set of comparison operators allowed for a marker in PEP 508, and add a regression test covering each of them. Signed-off-by: Daksha1611 <mehtadaksha1611@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5309
The operator list in
get_python_version_os()has<twice and no>:So
requests; python_version > "3.8"never matched and the marker was dropped from the dependencyextra_data, while>=on the same requirement was picked up fine.!=and~=were missing for the same reason.Replaced that list with the comparison operators PEP 508 allows in a marker, and added a test covering each of them.
sys_platformand the no-marker path are untouched.