No-components alert when importing to DejaCode#40 - #136
Merged
Merged
Conversation
* Deleted button definition (including modal trigger) in
componentDataTables.js constructor.
* Button action function added to button definition in
_createDataTable(tableID), including
* count based on DataTable parameter “dt” and
* if/then test to trigger “Upload Components to DejaCode” modal.
* Next step: modify to base test on Component table in AboutCodeDB
rather than DataTable.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Button “action” function converted to fat arrow function.
* If/then is based on testing length of array returned by
findAllComponents().
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Member
Author
|
In my latest commit:
|
jdaguil
reviewed
Jul 25, 2017
| if (components.length > 0) { | ||
| $('#componentExportModal').modal('show'); | ||
| } | ||
| else { |
Contributor
There was a problem hiding this comment.
Could you put the else on the same line as your if block’s closing brace?
Member
Author
There was a problem hiding this comment.
Will do @jdaguil . (I'll need to do the same for PR #135 but will wait in case you have other comments.)
Member
Author
jdaguil
suggested changes
Jul 25, 2017
* Moved start of "else" block to same line as "if" block's closing
brace.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
componentDataTables.jsconstructor._createDataTable(tableID), includingdtandComponenttable inAboutCodeDBrather than DataTable.
Signed-off-by: John M. Horan johnmhoran@gmail.com