Skip to content

Create new icons #382 - #409

Merged
steven-esser merged 3 commits into
developfrom
382-improve-scwb-icon
Dec 3, 2019
Merged

steven-esser merged 3 commits into
developfrom
382-improve-scwb-icon

Conversation

@johnmhoran

Copy link
Copy Markdown
Member
  • Created .png (Linux) and .ico (Windows) but .icns for macOS not yet created.

Signed-off-by: John M. Horan johnmhoran@gmail.com

* Created .png (Linux) and .ico (Windows) but .icns for macOS not yet created.

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran

Copy link
Copy Markdown
Member Author

@MaJuRG I've added icons for Linux and Win and code for Linux, Win and macOS -- but have not created the .icns for macOS. Please let me know what you think, and what changes if any you suggest, when you have the chance.

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmhoran Can you also add the source file you used to generate the various sizes/types etc? Once this is added I can create the macos .icns file.

@johnmhoran

Copy link
Copy Markdown
Member Author

@MaJuRG For the current proposed icon I have a krita source file named scwb_blue_square_02.ico.kra -- shall I add that to one of the /app-icon/ folders and do another commit and push?

@steven-esser

steven-esser commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Preferably, we would want the source to be in .svg format as this is portable and easily convertible.

I am not sure if you created the icon yourself or got it from another location, but you should be able to save/export the file to .svg format in krita

* Used vector layer rather than canvas.
* Created .png (Linux) and .ico (Win).
* Created .svg to be used for macOS .icns file
   (in /app-icon/mac/).

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran

Copy link
Copy Markdown
Member Author

@MaJuRG I used a single vector layer rather than the default canvas -- .svg file can be found in /app-icon/mac/ folder.

* Add MacOS formatted .icns icon file
* remove unnecessary svg file

Addresses: #383

Signed-off-by: Steven Esser <sesser@nexb.com>
@steven-esser

Copy link
Copy Markdown
Contributor

@johnmhoran Looks like we can use just a .png file to generate the MacOS .icns file. Sorry about that.
In my latest commit, I added the icns file for MacOS and removed the unnecessary svg file.

@steven-esser
steven-esser merged commit ee52d6f into develop Dec 3, 2019
@steven-esser
steven-esser deleted the 382-improve-scwb-icon branch December 3, 2019 19:40
@steven-esser steven-esser mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants