Skip to content

Added identifier for package nodes - #42

Closed
Rishav159 wants to merge 2 commits into
aboutcode-org:masterfrom
Rishav159:package-identifier
Closed

Rishav159 wants to merge 2 commits into
aboutcode-org:masterfrom
Rishav159:package-identifier

Conversation

@Rishav159

Copy link
Copy Markdown

The nodes that includes packages will now have '(P)' appended in their filename.

@pombredanne

Copy link
Copy Markdown
Member

@Rishav159 Thanks! @jdaguil your to review

@pombredanne
pombredanne requested a review from jdaguil March 1, 2017 13:46
@pombredanne

Copy link
Copy Markdown
Member

@Rishav159 could there be another way may be with an icon for the node rather than adding extra characters to the node name?

@Rishav159

Copy link
Copy Markdown
Author

@pombredanne I should not mess with the color of the circles present in the node as it represents the status. Maybe I append some icon in front of the node? Will that be fine ?

@pombredanne

Copy link
Copy Markdown
Member

@jdaguil what do you think?

@Rishav159

Copy link
Copy Markdown
Author

@pombredanne @jdaguil I changed the color of the text-background to green instead of appending '(P)' in the filenames, to identify if the files contain package information.
Please review.

@jdaguil

jdaguil commented Mar 1, 2017

Copy link
Copy Markdown
Contributor

Hi @Rishav159 I'll review this soon. For any pull requests, we would want to merge them into the develop branch and not master.

@Rishav159

Copy link
Copy Markdown
Author

@jdaguil Okay. I will make the PR again to the develop branch.

@Rishav159 Rishav159 closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants