Conversation
Member
|
@Rishav159 Thanks! @jdaguil your to review |
Member
|
@Rishav159 could there be another way may be with an icon for the node rather than adding extra characters to the node name? |
Author
|
@pombredanne I should not mess with the color of the circles present in the node as it represents the status. Maybe I append some icon in front of the node? Will that be fine ? |
Member
|
@jdaguil what do you think? |
Author
|
@pombredanne @jdaguil I changed the color of the text-background to green instead of appending '(P)' in the filenames, to identify if the files contain package information. |
Contributor
|
Hi @Rishav159 I'll review this soon. For any pull requests, we would want to merge them into the |
Author
|
@jdaguil Okay. I will make the PR again to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nodes that includes packages will now have '(P)' appended in their filename.