Move filter bar to the top in table view - #424
Conversation
Signed-off-by: Lakshay Angrish <angrishlakshay@gmail.com>
steven-esser
left a comment
There was a problem hiding this comment.
Two things:
-
I would prefer that the buttons controlling filter actions ("Activate Filters", etc) be visually different, separate buttons from the rest of the column view buttons.
-
Every time I go to select a value from the filter drop-downs, a column sort is triggered. This is not a behavior we want to have.
Signed-off-by: Lakshay Angrish <angrishlakshay@gmail.com>
Signed-off-by: Lakshay Angrish <angrishlakshay@gmail.com>
|
@MaJuRG I have made the suggested changes and updated the screenshot in the PR Description. |
Signed-off-by: Lakshay Angrish <angrishlakshay@gmail.com>
steven-esser
left a comment
There was a problem hiding this comment.
This is much better and we are almost there :)
One last request: Can you please style the filter buttons as buttons, not just links?
All in all, I still want these to be buttons, just not identical buttons to the column view buttons.
Does this make sense?
|
@MaJuRG I understand. It is still a button though, just with the |
|
A standard bootstrap button is fine I think |
Signed-off-by: Lakshay Angrish <angrishlakshay@gmail.com>
|
@MaJuRG Made the buttons look like before this PR, and updated the screenshot. |
steven-esser
left a comment
There was a problem hiding this comment.
Looks good, thanks for this.
Fixes #271
The table view now has all filters at the top