Update rtd 01 - #431
Merged
Merged
Update rtd 01#431
Conversation
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
suggested changes
Mar 22, 2020
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
This looks good, content-wise.
I left a few comments, mostly on the css override file. The repetition is only there to point out all the various instances. Other than that, this looks good.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Otherwise Travis test fails because by default, Sphinx expects the master doc to be contents.rst, which can't be found because there is no such file. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
approved these changes
Mar 23, 2020
Contributor
|
Something if off with Travis connection to PRs, but the build have passed so I am merging this. |
Member
Author
|
@MaJuRG Yes, I've been tracking this, the last Travis test passed but GH was showing it in progress, was writing a post to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.