Skip to content

Updating Issue template - #490

Closed
Dinesh101041 wants to merge 9 commits into
aboutcode-org:developfrom
Dinesh101041:develop
Closed

Dinesh101041 wants to merge 9 commits into
aboutcode-org:developfrom
Dinesh101041:develop

Conversation

@Dinesh101041

Copy link
Copy Markdown

No description provided.

@Dinesh101041 Dinesh101041 changed the title Updating pull request Updating Issue template Mar 24, 2021
Comment thread .github/ISSUE_TEMPLATE/bug-.md Outdated
Comment on lines +11 to +23
1. Full runnable code or full changes you made:
```
If making changes to the project itself, please use output of the following command:
git rev-parse HEAD; git diff

<put code or diff here>
```
2. What exact command you run:
3. __Full logs__ or other relevant observations:
```
<put logs here>
```
4. please simplify the steps as much as possible so they do not require additional resources to run,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really relevant to an Electron GUI application.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed sir please check

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dinesh101041 Thank you. Can you please sign off your commits and rebase them into a single, signed commit?

@Dinesh101041

Copy link
Copy Markdown
Author

Sir can your explain more what to do because i am not well in DCO workflow and i make the pull request through github web ui so unable to run a force command
or can i delete the pull request and branch and make a new pull request sir

@pratik0316

pratik0316 commented Mar 26, 2021

Copy link
Copy Markdown

Hi @Dinesh101041 , first rebase all commits to a single commit then , just put the flag -s when you are making the commit, to correct DCO .
Its is better to use the CLI always
You can follow this https://www.internalpointers.com/post/squash-commits-into-one-git

@Dinesh101041

Copy link
Copy Markdown
Author

Thank you sir i will do it
in between i ran into another doubt when setting scancode-workbench locally using node js
i cloned the repo and done the npm install command
after that how to run a 'Rebuild native Node.js modules against the app version of Node.js' for windows
i run this command .\node_modules\.bin\electron-rebuild.cmdbut it shows error
and after the running above command and npm start command we can upload a file into application?
i am asking because of first time i run the npm run command without running rebulid native command the application is launched but i am unable to upload files

can you help me out sir

@pratik0316

Copy link
Copy Markdown

I didn't get u correctly , u are not able to upload in git?

@Dinesh101041

Copy link
Copy Markdown
Author

no sir after running npm start command
the application is launched
image

but after clicking import json or open sql buttons i did not get any response sir

@pratik0316

Copy link
Copy Markdown

can you post the console logs if any?

@Dinesh101041

Dinesh101041 commented Mar 27, 2021

Copy link
Copy Markdown
Author

Sorry for late reply sir here is console log
image

and when running rebulid command getting exit code error sir
image

@pratik0316

Copy link
Copy Markdown

@Dinesh101041 ki think it's due to py version mismatch , deactivate the anaconda environment and give a try once

Pushpit07 and others added 2 commits March 28, 2021 18:49
Signed-off-by: Pushpit <pushpit07@gmail.com>

This commit fixes #487

Signed-off-by: Pushpit <pushpit07@gmail.com>

Update issue templates

bug

feature

template change
@Dinesh101041

Copy link
Copy Markdown
Author

done a rebase sir

@pratik0316

Copy link
Copy Markdown

@Dinesh101041 okay , just signoff commits

@Dinesh101041

Copy link
Copy Markdown
Author

please check now sir

@Aayush-hub

Copy link
Copy Markdown
Contributor

@Dinesh101041 You DCO check failure suggests that you didn't sign off the commits. Please run followings commands :

  • git rebase HEAD~9 --signoff
  • git push --force-with-lease origin develop

@Dinesh101041

Copy link
Copy Markdown
Author

i am getting merging conflicts on signof commit sir i am closing this pull request and create new one with all updation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants