Add support for python3 - #511
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
I had to modify build.py to fix the err occurring when running |
|
@pombredanne ^^ |
f747639 to
35b6540
Compare
|
Also, I realised just now that the |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
pombredanne
left a comment
There was a problem hiding this comment.
Thanks!
test-wise we likely want to upgrade de linux version and use a not such an advanced Python version... 3.or may be 3.7? being conservative there is best IMHO.
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
| @@ -134,17 +134,17 @@ def get_git_version(): | |||
| # this may fail with exceptions | |||
| cmd = 'git', 'describe', '--tags', '--long', '--dirty', | |||
| version = subprocess.check_output(cmd, stderr=subprocess.STDOUT).strip() | |||
There was a problem hiding this comment.
You probably would rather decode early using this: then the b prefix is not needed afterwards
| version = subprocess.check_output(cmd, stderr=subprocess.STDOUT).strip() | |
| version = subprocess.check_output(cmd, encoding='utf-8', stderr=subprocess.STDOUT).strip() |
There was a problem hiding this comment.
Hi, I tried that, but it gives error unexpected keyword arg 'encoding' on pyhon2
It works fine with python3 latest versions, but not with python 2.
Also, this guy faced a same issue: eliben/pycparser#296 (comment)
I've done decoding on the next line though, thereby removing need for b prefix
There was a problem hiding this comment.
Fair enough... we want to drop Python2 support alright!
pombredanne
left a comment
There was a problem hiding this comment.
I just have a minor nit picking for your review... This is looking good otherwise!
👍
|
did the decode for npm_bin too |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
Thanks again! |
Fixes #502