There are two issues encountered when uploading the binary directly as an input instead of an archive:
- we do not have a
to/ side at all (because we could not extract from the binary)
- we have the binary extracted with it's internal sections in files (and this causes errors in the symbol extraction/mapping)
If you start a d2d project with the following links as inputs:
https://github.com/PrismLauncher/PrismLauncher/archive/refs/tags/9.1.zip#from
https://github.com/PrismLauncher/PrismLauncher/releases/download/9.1/PrismLauncher-Windows-MinGW-w64-Setup-9.1.exe#to
We get only a to/ side and no from/ side as we cannot extract the binary.
If you start a d2d project with the following links as inputs:
https://github.com/PrismLauncher/PrismLauncher/archive/refs/tags/9.1.zip#from
https://github.com/PrismLauncher/PrismLauncher/releases/download/9.1/PrismLauncher-Windows-MinGW-w64-Setup-9.1.exe#to
We get only a to/ side and no from/ side as we cannot extract the binary.
If you start a d2d project with the following links as inputs:
https://github.com/musescore/MuseScore/archive/refs/tags/v4.4.4.zip#from
https://github.com/musescore/MuseScore/releases/download/v4.4.4/MuseScore-Studio-4.4.4.243461245-x86_64.paf.exe#to
The binary is extracted into it's sections into files and this is not intended.
We need to just copy the binary to the scannable codebase instead of trying to extract the contents into the scannable codebase. This is done here. This is a follow up to this commit where we tried to fix this initially but it seems like there are more cases.
Other project examples with incorrectly extracted binaries from #1470:
sqlitebrowser-v3.12.2
Notepad3-RC3_6.24.309.1
Tengine-lite-v1.2-pre
keepassxc-2.3.4
sdrangel-v7.22.5
FreeCAD-1.0.0
There are two issues encountered when uploading the binary directly as an input instead of an archive:
to/side at all (because we could not extract from the binary)If you start a d2d project with the following links as inputs:
We get only a
to/side and nofrom/side as we cannot extract the binary.If you start a d2d project with the following links as inputs:
We get only a
to/side and nofrom/side as we cannot extract the binary.If you start a d2d project with the following links as inputs:
The binary is extracted into it's sections into files and this is not intended.
We need to just copy the binary to the scannable codebase instead of trying to extract the contents into the scannable codebase. This is done here. This is a follow up to this commit where we tried to fix this initially but it seems like there are more cases.
Other project examples with incorrectly extracted binaries from #1470:
sqlitebrowser-v3.12.2Notepad3-RC3_6.24.309.1Tengine-lite-v1.2-prekeepassxc-2.3.4sdrangel-v7.22.5FreeCAD-1.0.0