Move MatchCode-related code - #1077
Merged
Merged
Conversation
JonoYang
force-pushed
the
matchcode-module
branch
from
February 14, 2024 01:40
25642e5 to
3164d91
Compare
pombredanne
approved these changes
Mar 12, 2024
pombredanne
left a comment
Member
There was a problem hiding this comment.
Looking good!
Please resolved conflicts and merge.
This was referenced Mar 12, 2024
* Move matchcode related code from pipes/purldb.py to pipes/matchcode.py
* Update scancode.io settings to get matchcode API settings
* This is done since matchcode and purldb are technically two seperate services with their own users, etc.
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
matchcode-module
branch
from
March 20, 2024 22:42
3164d91 to
8b1f584
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
tdruez
requested changes
Mar 21, 2024
tdruez
left a comment
Contributor
There was a problem hiding this comment.
The match_to_purldb references need to be updated in the documentation as well.
* Update references to match_to_purldb to match_to_matchcode in docs Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves matchcode related code from
scanpipe/pipes/purldb.pytoscanpipe/pipes/matchcode.py. Therequest_get()andrequest_post()functions fromscanpipe/pipes/purldb.pyhave also been brought over toscanpipe/pipes/matchcode.py. The docstring of theMatchToMatchCodepipeline has been updated to mention the limits of the pipeline.The following settings have been added:
MATCHCODEIO_URLMATCHCODEIO_USERMATCHCODEIO_PASSWORDMATCHCODEIO_API_KEYThis was done to reflect that MatchCode and PurlDB are two different services, where MatchCode may not always be co-located with PurlDB.