Implement multiple performance enhancements #70 - #110
Merged
Conversation
tdruez
commented
Mar 12, 2021
Contributor
- Run celery worker with the "threads" pool implementation.
- Implement parallelization with ProcessPoolExecutor for file and package scans.
- Add a SCANCODE_PROCESSES settings to control the multiprocessing CPUs count.
- Optimize "tag" type pipes using the update() API in place of save() on the QuerySet iteration.
- Refactor make_codebase_resource to remove the extra get query
Signed-off-by: Thomas Druez <tdruez@nexb.com>
…ge scans #70 Signed-off-by: Thomas Druez <tdruez@nexb.com>
….objects #70 Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
…70 Signed-off-by: Thomas Druez <tdruez@nexb.com>
in place of save() on the QuerySet iteration Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
pombredanne
approved these changes
Mar 12, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM! 👍 ... Just a small question wrt. docs
| proxy_redirect off; | ||
| client_max_body_size 100M; | ||
| proxy_read_timeout 600s; | ||
| client_max_body_size 10G; |
Member
There was a problem hiding this comment.
Do we have some indications of these defaults in the docs?
Contributor
Author
There was a problem hiding this comment.
No, we do not have much docs on the default webserver configuration in the context of running the app through docker-compose.
Not sure about the value of commenting each lines of a nginx configuration in the ScanCode.io docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.