Add compliance support based on OpenSSF Scorecard score - #1800
Merged
Merged
Conversation
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Contributor
You can now merge |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
tdruez
requested changes
Aug 4, 2025
tdruez
left a comment
Contributor
There was a problem hiding this comment.
Looks good, see various comments before the merge.
Also, could you add an entry in the CHANGELOG?
| return Response({"license_clarity_compliance_alert": clarity_alert}) | ||
|
|
||
| @action(detail=True, methods=["get"]) | ||
| def scorecard_compliance(self, request, *args, **kwargs): |
Contributor
There was a problem hiding this comment.
This needs a new entry in the REST API documentation, see _rest_api_license_clarity_compliance
Comment on lines
+72
to
+84
| if scorecard_policy and scorecard_data.score is not None: | ||
| try: | ||
| score = float(scorecard_data.score) | ||
| alert = scorecard_policy.get_alert_for_score(score) | ||
| except Exception: | ||
| alert = "error" | ||
|
|
||
| order = {"ok": 0, "warning": 1, "error": 2} | ||
| if worst_alert is None or order[alert] > order.get(worst_alert, -1): | ||
| worst_alert = alert | ||
|
|
||
| if worst_alert is not None: | ||
| self.project.update_extra_data({"scorecard_compliance_alert": worst_alert}) |
Contributor
There was a problem hiding this comment.
All this new logic should be moved to a pipe function. We want to keep the pipeline method a simple as possible. This would also make it easier to test (make sure to add one).
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
tdruez
approved these changes
Aug 11, 2025
|
|
||
| v35.2.0 (2025-08-01) | ||
| -------------------- | ||
| - Enhanced scorecard compliance support with: |
Contributor
There was a problem hiding this comment.
This should not be inside the v35.2.0 section since it is already released.
aayushkdev
pushed a commit
to aayushkdev/scancode.io
that referenced
this pull request
Aug 28, 2025
…g#1800) Signed-off-by: NucleonGodX <racerpro41@gmail.com>
aayushkdev
added a commit
to aayushkdev/scancode.io
that referenced
this pull request
Aug 28, 2025
…g#1800) Signed-off-by: NucleonGodX <racerpro41@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1794
This PR adds support for scorecard based compliance using the new refactored architecture created in #1799
The scorecard compliance alert is stored in project's extra data and fetched from there to be visible in UI and during check-compliance command, The alert is computed during the fetch_score pipeline.
Once #1799 is merged, I will rebase this PR to main to remove the previous commits.