Update skeleton - #39
Conversation
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Create copyright statement from holder information Signed-off-by: Jono Yang <jyang@nexb.com>
* This is used for the case where we are starting off a project and have not yet generated requirements files Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Replace all references to `tmp` with `venv` Signed-off-by: Jono Yang <jyang@nexb.com>
* Add --init option to configure.bat
* Update help text in configure and configure.bat
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update README.rst Signed-off-by: Jono Yang <jyang@nexb.com>
8f17516 to
51981b3
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
51981b3 to
9c78ddb
Compare
* Update README.rst with instructions for post-initialization usage Signed-off-by: Jono Yang <jyang@nexb.com>
| def get_license_keys(self): | ||
| try: | ||
| keys = LICENSING.license_keys(self.license_expression, unique=True, simple=True) | ||
| except license_expression.ExpressionParseError: |
There was a problem hiding this comment.
I ran into an issue with the license_expression library throwing an ExpressionParseError when I ran the bootstrap.py script without scancode-toolkit installed. The license expression for this package was the classifier strings that contain the license. The LICENSING object would balk at the symbol License. My initial reaction to this is to return a list that only contains unknown, but I am not sure if this would be the best thing to do.
|
The usage instructions should be moved to the docs directory rather than being placed in README.rst |
pombredanne
left a comment
There was a problem hiding this comment.
LGTM... super clean! 👍
I have just a few nits for your consideration... nand you may want to move the docs in its own directory outside of the README?
| if "%1" EQU "--init" ( | ||
| set "NO_INDEX= " | ||
| ) | ||
| if "%1" EQU "--python" ( |
There was a problem hiding this comment.
At this stage this can be removed entirely IMHO
| # ScanCode is a trademark of nexB Inc. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # See http://www.apache.org/licenses/LICENSE-2.0 for the license text. | ||
| # See https://github.com/nexB/scancode-toolkit for support or download. |
There was a problem hiding this comment.
you need to switch the URLs to skeleton
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Replace references to scancode-toolkit repo with links to the skeleton repo
* Remove --python option from configure.bat
Signed-off-by: Jono Yang <jyang@nexb.com>
This PR addresses #31 #33 #34 #37 #38