Minor fix for unnecessary operations. - #1
Conversation
257079e to
923c2da
Compare
|
@corona10 Thanks! |
|
were you able to run the tests locally alright btw? |
|
@pombredanne Sure! Everything worked fine. It will be great if there are some install guide for |
|
@corona10 the only thing needed normally is to checkout a clone and run |
|
I will merge this is in as soon as a the CI tests pass. |
|
@pombredanne That's nice tips. Thanks! |
|
Merged/ Thanks! |
|
Comment for future commits messages:
e.g rather than :
|
|
I summarized our guidelines here: https://github.com/nexB/aboutcode/wiki/Writing-good-commit-messages |
|
@pombredanne Sounds great. Thank you for complete documentations. I will take a look at it and follow. |
Add initial skeleton files
For this weekend, I am going to read your repos.
Actually, this PR is not significant.
Just one thing I noticed, while I read your code.
There was an unnecessary operations which is to find the smallest pid.
If
tsdoes not exist, it doesn't have to compare old one.