Write correctly to files #3 - #4
Merged
Merged
Conversation
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Somehow a recent commit did trash writing to files. A separate commit adds end to end testing for all write operations Reference: #3 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We want strace and graphviz dot installed for the new end to end tests Reference: #3 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #3
It also adds an end to end test from scratch to test running as a command line in a
sub-process the same way things run otherwise.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com