Skip to content

Enhance quickstart guide with less noise and more troubleshooting guidelines - #2435

Merged
Link- merged 3 commits into
masterfrom
Link-/update-quickstart-guide
Mar 23, 2023
Merged

Link- merged 3 commits into
masterfrom
Link-/update-quickstart-guide

Conversation

@Link-

@Link- Link- commented Mar 23, 2023

Copy link
Copy Markdown
Member

Context

The commit log is available already, no need to include in the quickstart guide, the change logs suffice. I've also included the recommendations to resolve the permissions mismatch problem we've been observing when running in kubernetes mode.

@Link-
Link- requested review from a team, mumoshu, nikola-jokic and toast-gear as code owners March 23, 2023 12:23
nikola-jokic
nikola-jokic previously approved these changes Mar 23, 2023

@nikola-jokic nikola-jokic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for documenting this! 🚀

```yaml
spec:
securityContext:
fsGroup: 123

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will 1001 also work?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we would want to map to the runner's UID instead of its GID?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, just asking, in case the customer doesn't like 123. 😄

@Link-
Link- merged commit 37f93b7 into master Mar 23, 2023
@Link-
Link- deleted the Link-/update-quickstart-guide branch March 23, 2023 15:41
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants