Repository navigation
JAVA_HOME is not set correctly on MacOS for local (jdkFile) installed JDKs that are present in the tool cache #396
Description
Activity
hi @erwin1, thank you for the report. We will take a look at it
By the way, could you provide us public repo with repro steps?
Thanks.
Here's a public repo: https://github.com/erwin1/setup-java-mac-sscce
On a hosted runner it's a bit harder to reproduce because every run happens on a different runner (so less chance of having a tool cache).Although I was able to reproduce with a trick to use setup-java again in the same job.
This fails:
https://github.com/erwin1/setup-java-mac-sscce/actions/runs/3344915283/jobs/5539822614And using the proposed fix from #397 it works:
https://github.com/erwin1/setup-java-mac-sscce/actions/runs/3344942099/jobs/5539881412added 2 unit tests of which one fails (
java is resolved from toolcache including Contents/Home on MacOS) without the proposed fixAny chance we can move this forward?
hi @erwin1, sorry for the delayed answer, thank you for the repo I will take a look again :)
Reacted by Erwin MorrheyWe are still regularly running into this issue, so it would be great to get a review on the PR. Thanks!
Hello @erwin1. We've merged your pull request. For now you can try to use this changes with
actions/setup-java@main. We'll ping you when new release is ready.For now I'm going to reopen it until we release a new version.
Thanks, using
@mainworks as expected now:
https://github.com/erwin1/setup-java-mac-sscce/actions/runs/4606608821Hi, @erwin1 👋 The new version of the setup-java is released. Please, check it out.
I'm going to close this issue, If you have any additions or questions feel free to ping us.
Reacted by Erwin Morrhey
Description:
Local installed JDKs using the jdkFile option that are already present in the tool cache are not checked for suffix 'Contents/Home' on macos, so as a result the JAVA_HOME is not set correctly.
Task version:
v3
Platform:
Runner type:
Repro steps:
Expected behavior:
When the JDK is available in the tool cache, JAVA_HOME must be set correctly.
Actual behavior:
When the JDK is available in the tool cache, JAVA_HOME is set without checking if the JDK is placed in 'Contents/Home'