Skip to content

Add "Install multiple JDKs" README section - #351

Merged
marko-zivic-93 merged 4 commits into
actions:mainfrom
akv-platform:v-sdolin/issue-44
Jul 15, 2022
Merged

marko-zivic-93 merged 4 commits into
actions:mainfrom
akv-platform:v-sdolin/issue-44

Conversation

@dsame

@dsame dsame commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Description:
The PR it to clarify how to use multiple JDKs during build

Related issue:
link to the related issue.

@dsame
dsame requested a review from a team July 7, 2022 04:46

@laeubi laeubi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor remarks.

Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
Comment thread README.md
@slawekjaranowski

Copy link
Copy Markdown

Hi,
setup-java already set some of environment like: JAVA_HOME_11_X64 maybe simple should set JAVA_HOME_11 also ...

@laeubi

laeubi commented Jul 7, 2022

Copy link
Copy Markdown

JAVA_HOME_11_X64

As I learned is not from the setup action (@v3) but from the container itself.

@dsame

dsame commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

Hi, setup-java already set some of environment like: JAVA_HOME_11_X64 maybe simple should set JAVA_HOME_11 also ...

I would leave the naming on the pipeline owner will and prefer to avoid any "standard" names because the can clash with same predefined variables. It is kind of naive namespacing.

@dsame dsame assigned dsame and unassigned dsame Jul 13, 2022
Comment thread README.md Outdated
Comment thread README.md
@marko-zivic-93
marko-zivic-93 merged commit 46f0194 into actions:main Jul 15, 2022
tdfacer pushed a commit to ifit/setup-java that referenced this pull request Oct 7, 2025
Add "Install multiple JDKs" README section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants