Skip to content

Use dummy SDL video driver for native sim - #11303

Merged
dhalbert merged 2 commits into
adafruit:mainfrom
tannewt:use_dummy_sdldriver
Sep 4, 2026
Merged

dhalbert merged 2 commits into
adafruit:mainfrom
tannewt:use_dummy_sdldriver

Conversation

@tannewt

@tannewt tannewt commented Sep 3, 2026

Copy link
Copy Markdown
Member

On github actions, the offscreen driver exposed a thread teardown race condition. The driver switch avoids it but the zephyr commit also manages it.

Also tweak the reset_port() exit count to be more explicit and include the safe mode message print.

Fixes #11300

On github actions, the offscreen driver exposed a thread teardown race
condition. The driver switch avoids it but the zephyr commit also
manages it.

Also tweak the reset_port() exit count to be more explicit and include
the safe mode message print.

Fixes micropython#11300
@tannewt
tannewt requested a review from dhalbert September 3, 2026 22:12
dhalbert
dhalbert previously approved these changes Sep 3, 2026

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This was a a hard bug - thanks!

@dhalbert

dhalbert commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

A different failure in zephyr-tests

@tannewt

tannewt commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

@dhalbert please rereview. The zephyr test passed. only the native sim build is pending

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert
dhalbert merged commit 8857b1f into adafruit:main Sep 4, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zephyr-cp: test_saved_word_survives_reboot_into_safe_mode flakes on main (native_sim aborts with heap corruption)

2 participants