Repository navigation
[pull] main from nodejs:main - #1374
Merged
Merged
Conversation
The compat response defers 'finish' and 'close' for a HEAD request until response.end(), because the stream of a headers-only response closes as soon as the headers are sent. The same deferral also applied to a HEAD stream that closed before any response was sent, for example when the client cancelled it or the session was destroyed. Nothing was left to call end(), so the response never emitted 'close' and the abort could not be observed on it. Defer only once the headers were sent, and otherwise close the response as for any other method. The writable side of a HEAD stream is finished from the start, so 'finish' is emitted only after the headers were sent, and an aborted HEAD response does not report success. Assisted-by: Opus 5.5 Signed-off-by: Robert Nagy <ronagy@icloud.com> PR-URL: #66310 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Remove entries for test-performance-function and test-report-fatal-error. Both tests were renamed, so their original names no longer match tests. Refs: #54803 Refs: #43457 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The entries added for Linux arm64 debug failures use arch==arm, so they do not match that configuration. Since 9ea6182, the shared SEA guard also correctly skips executable tests on Linux debug builds. Remove the stale entries. The tests without that guard only validate SEA configuration errors. Refs: #63749 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The test could finish its workload without recording a workload frame. 0ab4a1c increased the non-Windows workload from fib(30) to fib(40), and 92e6342 moved Profiler.setSamplingInterval before Profiler.start so the requested interval takes effect. Remove the flaky expectation left over from before those fixes. Refs: #27611 Refs: #32168 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Background compilation could deadlock at process exit: DrainTasks waited for the compiler task while that task waited for main-thread garbage collection. Since 5fb879c, only user-blocking tasks count toward that wait, excluding ordinary background compilation. Remove the old flaky expectations for test-http2-large-file and test-fs-read-stream-concurrent-reads. Refs: #47409 Refs: #51862 Refs: #54918 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Disconnecting the inspector can race with its final notification write. If EOF resets the socket first, the write used to dereference a null TCP handle. 8a84e6b added guards for writes after disconnect. Removing those guards reproduces the loader test's SIGSEGV under a scheduling-delay probe; the normal binary passes the same probe. Remove the flaky expectations left over from before that fix. Refs: #54346 Refs: #34833 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )