Repository navigation
[pull] main from nodejs:main - #1380
Merged
Merged
Conversation
zstdCompress() writes its input and ends the frame in separate calls, so zstd cannot infer the input size the way it does for zstdCompressSync(), and sizes its tables for an unbounded stream. Default pledgedSrcSize to the input's byte length. The output is now identical to zstdCompressSync() and several times faster at higher levels. An explicit pledgedSrcSize, or a string with a custom defaultEncoding, keeps the current behavior. Signed-off-by: James Ross <james@jross.me> PR-URL: #66358 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Signed-off-by: James Ross <james@jross.me> PR-URL: #66358 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Passing decodeStrings: false to a zlib stream, or to an async convenience method, let strings reach the native handle, which aborts the process on its Buffer check. Force decodeStrings back to true, as is already done for encoding and objectMode. Signed-off-by: James Ross <james@jross.me> PR-URL: #66359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Return SQLITE_CONSTRAINT from xBestIndex() when a hidden column has an equality constraint that is not usable at the current point in the query plan. Accepting such a plan makes xFilter() call rows() with null, silently dropping rows and returning an empty result, e.g. for "SELECT DISTINCT * FROM m(t.a) JOIN t ON t.a = m.a". Cost estimates alone cannot enforce parameter dependencies; rejecting the plan lets SQLite pick an ordering where the parameter value is available. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode PR-URL: #66215 Fixes: #66214 Reviewed-By: Guilherme Araújo <arauujogui@gmail.com>
Exporting a key in 'raw', 'raw-public' or 'raw-seed' format when the key type does not match (e.g. an ECDSA private key as 'raw', or an ML-KEM public key as 'raw-seed') fell through to the generic NotSupportedError. The Web Crypto and modern-algos export key steps require an InvalidAccessError in these cases. Mirror exportKeySpki() and exportKeyPkcs8(): select the exporter per algorithm first, then check the key type, and drop the type guards around the call sites in exportKeySync(). Formats an algorithm does not support (e.g. 'raw' for ML-DSA) still throw NotSupportedError. This also fixes wrapKey(), which uses the same export path. Assisted-by: a closed-source coding agent Signed-off-by: koreahghg <koreahghg@gmail.com> PR-URL: #66217 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )