Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Add --disable-default-apps-flag for live preview - #533

Merged
marcelgerber merged 1 commit into
adobe:masterfrom
petetnt:master
Sep 12, 2015
Merged

marcelgerber merged 1 commit into
adobe:masterfrom
petetnt:master

Conversation

@petetnt

@petetnt petetnt commented Sep 8, 2015

Copy link
Copy Markdown
Collaborator

Fixes adobe/brackets#11617.

Currently when Brackets launches live preview (for the first time), it uses a new profile. Chrome then proceeds to install the default Chrome apps (Youtube, Gmail, Google Search, Web Store, Google Docs...) for the said user. This can create situations like described in adobe/brackets#11617.

This PR adds --disable-default-apps-flag for remote debugging arguments, which disables that said behaviour. (Plus it could/should make the first live preview experience a tad bit faster 🔥)

@nethip

nethip commented Sep 8, 2015

Copy link
Copy Markdown
Contributor

@petetnt Thanks for investigating this issue and fixing it as well! Did you get a chance to run unit tests with this PR. If all the tests are passing, then we are good to go with this PR 👍

@petetnt

petetnt commented Sep 8, 2015

Copy link
Copy Markdown
Collaborator Author

@nethip, successfully ran all the LivePreview related tests.

However some instability because I am building the binary with Visual Studio 2013... GetVersionEx is deprecated -> it won't compile even with turning Treat Warnings as Errors (/WX) off (/WX-) so I had to hack around those which might be the cause (running the tests against brackets#master + brackets-shell#master randomly fails tests too). 😔

@marcelgerber

Copy link
Copy Markdown
Contributor

I ran all Live Preview tests as well, both with an existing live-dev-profile and without. Everything was fine.

Merging.

marcelgerber pushed a commit that referenced this pull request Sep 12, 2015
Add --disable-default-apps-flag for live preview
@marcelgerber
marcelgerber merged commit e5e2643 into adobe:master Sep 12, 2015
@petetnt

petetnt commented Sep 13, 2015

Copy link
Copy Markdown
Collaborator Author

Thanks @marcelgerber 👍

@nethip

nethip commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

Thanks @marcelgerber @petetnt

marcelgerber pushed a commit that referenced this pull request Dec 8, 2015
Add --disable-default-apps-flag for live preview
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants