Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[Themes] Restore Font Size (Ctrl+0) no longer works #8381

Closed

Description

@redmunds

I just synced to master and Restore Font Size (Ctrl+0) no longer works, so I'm assuming this is related to Themes work.

Activity

  1. added this to the Release 0.42 milestone on Jul 14, 2014
  2. peterflynn commented on Jul 14, 2014

    @peterflynn
    Member

    Adding 0.42 milestone since we think this is a regression

  3. dangoor commented on Jul 15, 2014

    @dangoor
    Contributor
  4. MiguelCastillo commented on Jul 15, 2014

    @MiguelCastillo
    Contributor

    Yup, I am merging latest into fonts PR and this is next on my list

  5. MiguelCastillo commented on Jul 15, 2014

    @MiguelCastillo
    Contributor

    So this issue with this one is that Themes takes over the fonts elements that brackets creates. This is a leftover from the code being an extension and brackets not providing an interface to interact with font settings.
    https://github.com/adobe/brackets/blob/master/src/view/ThemeView.js#L48

    This issue will go away when we get this #8305 done

  6. dangoor commented on Jul 22, 2014

    @dangoor
    Contributor

    This is fixed on master by #8492.

    FBNC to @redmunds

  7. redmunds commented on Jul 22, 2014

    @redmunds
    ContributorAuthor

    Confirmed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions