Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Sample projects: remove trailing whitespace on non-blank lines, fix arrow - #10926

Merged
abose merged 2 commits into
adobe:masterfrom
valtlai:valtlait/sample-project
May 29, 2015
Merged

abose merged 2 commits into
adobe:masterfrom
valtlai:valtlait/sample-project

Conversation

@valtlai

@valtlai valtlai commented Apr 17, 2015

Copy link
Copy Markdown
Contributor
  • remove trailing whitespace on non-blank lines
  • fix an arrow: < to >
  • remove the blank line just before </p>

See #10920, comments 2–3

@valtlai valtlai changed the title Sample projects: remove trailing whitespace on non-empty lines, fix arrow Sample projects: remove trailing whitespace on non-blank lines, fix arrow Apr 17, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pantkowiak @ybayer Looks like there is an ALF issue here -- both the French & Japanese translations had this character escaped when it should not have been. We should make sure the next ALF update doesn't cause this problem to come back.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn I did some digging, and this is not an ALF issue. Somehow the opening bracket for </kbd> tag was escaped during our pre-process for translation and post-process. This was missed in post-process, because we never had such issue. I've added info about this to our instructions, so this should not be an issue in the future:)

@peterflynn

Copy link
Copy Markdown
Member

The HTML spec says > "SHOULD" be escaped as &gt;, but since it also says the motivation for that is buggy older browsers, I think we can ignore that advice -- that change here is ok.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other languages have this extra line also. Do you want to remove it in all of them for consistency? (Please squash commits if you do, for history cleanliness).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn Done.

abose added a commit that referenced this pull request May 29, 2015
Sample projects: remove trailing whitespace on non-blank lines, fix arrow
@abose
abose merged commit 5f2ccda into adobe:master May 29, 2015
@valtlai
valtlai deleted the valtlait/sample-project branch October 3, 2015 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants